Posts: Fix hierarchical parent selection for pages with non-published ancestors#10897
Posts: Fix hierarchical parent selection for pages with non-published ancestors#10897himanshupathak95 wants to merge 10 commits intoWordPress:trunkfrom
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
4adde32 to
eb692e1
Compare
eb692e1 to
e3025e7
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: https://core.trac.wordpress.org/ticket/11235
Fixes a bug where published child pages with non-published (trashed, draft, pending, or private) parents disappeared from parent selection dropdowns.
When a page's parent was trashed or set to draft/pending status, that page could no longer be selected as a parent for other pages, even though it was still published and functioning normally.
This pr modified
get_page_children()to include orphaned pages when building hierarchical trees. This ensures published pages remain available for selection regardless of their parent's status.Also updated the admin parent dropdown to query multiple post statuses, making the parent's status visible in the UI when applicable. This PR might affect the performance and I am open to discuss a better approach if performance is affected. Tests are still a WIP, trying out new edge cases.
Testing
Inspired by and, props to the patch - https://core.trac.wordpress.org/attachment/ticket/11235/11235.diff